Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: In ssm source auto parse only object JSON notation #9747

Merged
merged 1 commit into from Jul 15, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jul 15, 2021

Closes: #9742

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #9747 (25c7ce8) into master (7078449) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9747   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files         328      328           
  Lines       12590    12591    +1     
=======================================
+ Hits        10840    10841    +1     
  Misses       1750     1750           
Impacted Files Coverage Δ
...on/variables/sources/instance-dependent/get-ssm.js 91.11% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7078449...25c7ce8. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik July 15, 2021 08:17
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call, change looks good 👍

@medikoo medikoo merged commit 8c741d1 into master Jul 15, 2021
@medikoo medikoo deleted the 0715-fix-ssm-secrets-parsing branch July 15, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSM variable resolution issue for SecureString
2 participants