diff --git a/api/src/main/java/io/serverlessworkflow/api/ObjectMapperFactory.java b/api/src/main/java/io/serverlessworkflow/api/ObjectMapperFactory.java index 25a3f2a2..4c7393d0 100644 --- a/api/src/main/java/io/serverlessworkflow/api/ObjectMapperFactory.java +++ b/api/src/main/java/io/serverlessworkflow/api/ObjectMapperFactory.java @@ -34,11 +34,11 @@ class ObjectMapperFactory { private static final ObjectMapper yamlMapper = configure(new ObjectMapper(new YAMLFactory().enable(Feature.MINIMIZE_QUOTES))); - public static final ObjectMapper jsonMapper() { + public static ObjectMapper jsonMapper() { return jsonMapper; } - public static final ObjectMapper yamlMapper() { + public static ObjectMapper yamlMapper() { return yamlMapper; } @@ -49,7 +49,7 @@ private static ObjectMapper configure(ObjectMapper mapper) { validationModule.setDeserializerModifier(new BeanDeserializerModifierWithValidation()); return mapper - .setSerializationInclusion(Include.NON_NULL) + .setDefaultPropertyInclusion(Include.NON_NULL) .configure(SerializationFeature.INDENT_OUTPUT, true) .configure(SerializationFeature.WRITE_EMPTY_JSON_ARRAYS, false) .configure(SerializationFeature.WRITE_NULL_MAP_VALUES, false) diff --git a/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowModelFactory.java b/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowModelFactory.java index 1475b71e..a65e930f 100644 --- a/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowModelFactory.java +++ b/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowModelFactory.java @@ -51,6 +51,7 @@ default WorkflowModel fromAny(WorkflowModel prev, Object obj) { return fromAny(obj); } + @SuppressWarnings("unchecked") default WorkflowModel fromAny(Object obj) { if (obj == null) { return fromNull(); @@ -70,10 +71,6 @@ default WorkflowModel fromAny(Object obj) { return from((Map) obj); } else if (obj instanceof WorkflowModel model) { return model; - } else if (obj instanceof CloudEventData ce) { - return from(ce); - } else if (obj instanceof CloudEvent ce) { - return from(ce); } else { return fromOther(obj); } diff --git a/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/JsonUtils.java b/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/JsonUtils.java index 6434c6f5..146df093 100644 --- a/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/JsonUtils.java +++ b/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/JsonUtils.java @@ -162,7 +162,9 @@ public static JsonNode fromString(String value) { private static Object toJavaValue(ObjectNode node) { Map result = new HashMap<>(); - node.fields().forEachRemaining(iter -> result.put(iter.getKey(), toJavaValue(iter.getValue()))); + node.properties() + .iterator() + .forEachRemaining(iter -> result.put(iter.getKey(), toJavaValue(iter.getValue()))); return result; } diff --git a/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/MergeUtils.java b/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/MergeUtils.java index aca5d63d..a94b7ff1 100644 --- a/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/MergeUtils.java +++ b/impl/jackson/src/main/java/io/serverlessworkflow/impl/jackson/MergeUtils.java @@ -19,7 +19,6 @@ import com.fasterxml.jackson.databind.node.ArrayNode; import com.fasterxml.jackson.databind.node.ObjectNode; import java.util.HashSet; -import java.util.Iterator; import java.util.Map; import java.util.Set; @@ -56,9 +55,7 @@ public static JsonNode merge(JsonNode src, JsonNode target, boolean mergeArray) private static ObjectNode mergeObject(JsonNode src, ObjectNode target, boolean mergeArray) { if (src.isObject()) { - Iterator> mergedIterator = src.fields(); - while (mergedIterator.hasNext()) { - Map.Entry entry = mergedIterator.next(); + for (Map.Entry entry : src.properties()) { JsonNode found = target.get(entry.getKey()); target.set( entry.getKey(), diff --git a/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenIDCHTTPWorkflowDefinitionTest.java b/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenIDCHTTPWorkflowDefinitionTest.java index 7cecf9e5..5c038f62 100644 --- a/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenIDCHTTPWorkflowDefinitionTest.java +++ b/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenIDCHTTPWorkflowDefinitionTest.java @@ -17,7 +17,7 @@ import static io.serverlessworkflow.api.WorkflowReader.readWorkflowFromClasspath; import static io.serverlessworkflow.impl.test.OAuthHTTPWorkflowDefinitionTest.fakeAccessToken; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertTrue; import com.fasterxml.jackson.databind.ObjectMapper; diff --git a/pom.xml b/pom.xml index 96faa82a..3be3738f 100644 --- a/pom.xml +++ b/pom.xml @@ -52,7 +52,7 @@ 17 ${java.version} - ${java.version} + ${java.version} UTF-8 3.9.11 @@ -94,9 +94,9 @@ 9.0.1.Final 6.0.0 - 1.4.1-beta10 + 1.5.0-beta11 - 1.4.0 + 1.5.0 true @@ -309,10 +309,6 @@ true true - ${maven.compiler.source} - ${maven.compiler.target} - ${maven.compiler.source} - ${maven.compiler.target} true -Xlint:unchecked