Skip to content

Add SDK #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

Add SDK #1

merged 1 commit into from
Nov 22, 2023

Conversation

@rmcdaniel
Copy link
Collaborator

@rmcdaniel rmcdaniel commented Nov 22, 2023

This mainly follows how the Python SDK works. There is a single BaseObject class that handles the hydration. There are several commands for automated refactoring, coding standards, static analysis and unit tests.

composer rector = "vendor/bin/rector",
composer ecs = "vendor/bin/ecs check --fix",
composer stan = "vendor/bin/phpstan analyse src tests",
composer test = "phpunit --testdox"

@rmcdaniel
Add SDK
06b9ac8 
Signed-off-by: Richard McDaniel <richard.lee.mcdaniel@gmail.com>
cdavernas
cdavernas approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!!!
Many thanks ❤️

@cdavernas cdavernas merged commit a51196a into serverlessworkflow:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdavernas cdavernas cdavernas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmcdaniel @cdavernas