Bootstrap project using kubebuilder 3.1.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are these inter-operable with kubebuilder? |
scothis
reviewed
Aug 16, 2021
Commands used to bootstrap: kubebuilder init --domain="service.binding" --repo="github.com/kubernetes-sigs/service-binding" --owner="The Kubernetes Authors" --project-name="service-binding-operator" kubebuilder edit --multigroup=true kubebuilder create api --crd-version="v1" --group="" --version="v1alpha2" --kind="ServiceBinding" --resource --controller kubebuilder create api --crd-version="v1" --group="" --version="v1alpha2" --kind ClusterApplicationResourceMapping --resource --controller make generate
baijum
changed the title
|
I have bootstrapped the project using kubebuilder. Force pushed the commit as the old commit is obsolete. |
scothis
reviewed
Aug 17, 2021
PROJECT
Outdated
| version: v1alpha2 | ||
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true |
| @@ -0,0 +1,24 @@ | |||
| # permissions for end users to edit clusterapplicationresourcemappings. | |||
There was a problem hiding this comment.
The RBAC-related files are auto-generated by kubebuilder. Probably helpful for those who are packing this project (say Helm charts).
There was a problem hiding this comment.
ok. I was a bit surprised to not see it listed in the kustomization.yaml file, even if commented
| @@ -0,0 +1,20 @@ | |||
| # permissions for end users to view clusterapplicationresourcemappings. | |||
| @@ -0,0 +1,24 @@ | |||
| # permissions for end users to edit servicebindings. | |||
| @@ -0,0 +1,20 @@ | |||
| # permissions for end users to view servicebindings. | |||
scothis
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands used to bootstrap: