Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Reimplement Setting#POST endpoint #89

Open
adamczykba opened this issue Jun 17, 2019 · 1 comment
Open

Reimplement Setting#POST endpoint #89

adamczykba opened this issue Jun 17, 2019 · 1 comment
Labels

Comments

@adamczykba
Copy link
Contributor

Describe the bug
POST endpoint in SettingsResource aside from creating new records also overwrites existing ones. There should be some check for duplicates.

To Reproduce
Steps to reproduce the behavior:

  1. Create new Setting through REST request
  2. Send the same request second time (optionally try to change some value to see the change)
  3. Go to Settings table in DB and see that record has been changed

Expected behavior
POST endpoint should only create new records. It should not be able to update them.

Observed behavior
SettingsResource#POST request overwrites existing settings records

Screenshots
N/A

Additional context
N/A

@adamczykba adamczykba added the bug label Jun 17, 2019
@Crystalzord
Copy link
Contributor

Crystalzord commented Dec 9, 2019

I already commented on this here: #164
The implementation of saveConfigurationSetting method from OperatorServiceBean class in the oscm repository and the ConfigurationKey class from oscm-interfaces need refactoring in order to make the POST endpoint work correctly.

I edited the task name.

@Crystalzord Crystalzord changed the title Setting#POST enpoint overwrites existing setting records Reimplement Setting#POST endpoint Dec 9, 2019
@Crystalzord Crystalzord added task and removed bug labels Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants