Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 1.0 #109

Closed
nox opened this issue Feb 9, 2017 · 4 comments
Closed

Publish 1.0 #109

nox opened this issue Feb 9, 2017 · 4 comments
Milestone

Comments

@nox
Copy link
Member

@nox nox commented Feb 9, 2017

Rust 1.15 is out, so that means we can have 1.0 now, right? :)

@ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Feb 9, 2017

#104 and #103 should probably be closed first.

@aldanor
Copy link

@aldanor aldanor commented Feb 11, 2017

A very minor thing, release-wise, does it make sense to relax deps version requirements down to minor number? E.g. it's currently

[dependencies]
byteorder = "1.0.0"
num-traits = "0.1.32"

[dependencies.serde]
version = "0.9.*"

[dev-dependencies]
serde_derive = "0.9.*"

but I guess it could be just

[dependencies]
byteorder = "1.0"
num-traits = "0.1"

[dependencies.serde]
version = "0.9"

[dev-dependencies]
serde_derive = "0.9"
@nox
Copy link
Member Author

@nox nox commented Feb 11, 2017

It's exactly the same thing, AFAIK, except for "0.1.32" being a subset of "0.1". Does it work with "0.1.0"?

@aldanor
Copy link

@aldanor aldanor commented Feb 11, 2017

Yep it's the same thing except doesn't pin the micro version (third component), which is quite customary to do. As I said, it's really a minor thing..

@TyOverby TyOverby modified the milestone: 1.0 Feb 23, 2017
@TyOverby TyOverby closed this Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.