Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions `deserialize` and `deserialize_from` are confusing #155

Closed
dtolnay opened this issue Apr 28, 2017 · 2 comments
Closed

Functions `deserialize` and `deserialize_from` are confusing #155

dtolnay opened this issue Apr 28, 2017 · 2 comments

Comments

@dtolnay
Copy link
Collaborator

@dtolnay dtolnay commented Apr 28, 2017

It sounds like we picked two different names for the same thing and randomly allocated one to each signature. Both functions are deserializing from something.

@TyOverby
Copy link
Collaborator

@TyOverby TyOverby commented Apr 28, 2017

deserialize_slice and deserialize_from_reader?

Same argument applies to the encoding APIs as well

@dtolnay
Copy link
Collaborator Author

@dtolnay dtolnay commented Apr 28, 2017

The Rust convention is from_xyz.

@TyOverby TyOverby closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.