Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or hide bincode::internal #156

Closed
dtolnay opened this issue Apr 28, 2017 · 2 comments
Closed

Rename or hide bincode::internal #156

dtolnay opened this issue Apr 28, 2017 · 2 comments
Milestone

Comments

@dtolnay
Copy link
Collaborator

@dtolnay dtolnay commented Apr 28, 2017

It is confusing to have this module with a ton of public functionality in it. Am I allowed to use it? Is it reserved for internal bincode use? What makes it internal? Why is it public and visible in the docs?

@TyOverby
Copy link
Collaborator

@TyOverby TyOverby commented Apr 28, 2017

It should probably be renamed back to "endian_choice"

@dtolnay
Copy link
Collaborator Author

@dtolnay dtolnay commented Apr 28, 2017

I don't understand the logic for all of what is currently in internal but a simpler bincode::endian::Deserializer makes perfect sense to me. Things that have nothing to do with endian choice (like ErrorKind) should probably not be exported under endian_choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.