Reader and writer should be taken by value

[dtolnay]

pub fn deserialize_from<R: ?Sized, T, S>(reader: &mut R, size_limit: S)

pub fn serialize_into<W: ?Sized, T: ?Sized, S>(writer: &mut W, value: &T, size_limit: S)

This is obnoxious when reading or writing some IO stream that is used only for bincode.

bincode::deserialize_from(File::open(f)?, infinite)

The standard library implements Read for &mut R and Write for &mut W so if these methods take the argument by value, callers can keep passing &mut like before if they want.

[TyOverby]

Agree

[fadeevab]

For anyone who wonders what to do now to not move the reader:

let f = File::open(f)?;
bincode::deserialize_from(f.by_ref(), infinite)?; // reference is moved, file is not
bincode::deserialize_from(f.by_ref(), infinite)?; // reference is moved, file is not
bincode::deserialize_from(f, infinite)?; // file is moved, you cannot use one further