Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for sequence without a known length #165

Closed
dtolnay opened this issue Apr 28, 2017 · 2 comments
Closed

Error message for sequence without a known length #165

dtolnay opened this issue Apr 28, 2017 · 2 comments
Milestone

Comments

@dtolnay
Copy link
Collaborator

@dtolnay dtolnay commented Apr 28, 2017

bincode can't encode infinite sequences

A couple things:

  • Neither can Serde!
  • This message is used for maps too, so it should be more general or split into two messages.
  • This message doesn't help the user fix the problem. ("Make your sequence less infinite"?)
@dtolnay
Copy link
Collaborator Author

@dtolnay dtolnay commented Apr 28, 2017

Something like this might work better:

Bincode requires sequence length to be available before serializing any elements

@dtolnay dtolnay added this to the 1.0 milestone Jul 20, 2017
@TyOverby
Copy link
Collaborator

@TyOverby TyOverby commented Oct 14, 2017

Fixed in eddf897

@TyOverby TyOverby closed this Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.