Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of IoError variant #178

Closed
dtolnay opened this issue Apr 28, 2017 · 0 comments
Closed

Naming of IoError variant #178

dtolnay opened this issue Apr 28, 2017 · 0 comments
Milestone
1.0

Comments

@dtolnay
Copy link
Collaborator

@dtolnay dtolnay commented Apr 28, 2017

I prefer the convention that the error-chain docs show, for example.

Io(io::Error),
Fmt(fmt::Error),
Csv(csv::Error),
Json(serde_json::Error),
// etc

Including "Error" in the name of an error variant seems redundant.
@ZoeyR ZoeyR mentioned this issue Jul 19, 2017
Merged
@dtolnay dtolnay added this to the 1.0 milestone Jul 20, 2017
@dtolnay dtolnay closed this in #194 Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@dtolnay
You can’t perform that action at this time.