Set is_human_readable to false

[dtolnay]

I have not released this yet but I will in the next few days. serde-rs/serde#1044

trait Serializer {
    /* ... */

    fn is_human_readable(&self) -> bool { true }
}

trait Deserializer<'de> {
    /* ... */

    fn is_human_readable(&self) -> bool { true }
}

Bincode should override these to false to get more compact representation for types like IpAddr and Datetime.

[TyOverby]

👍

[dtolnay]

• Serializer::is_human_readable
• Deserializer::is_human_readable

[Marwes]

Would there be any reason to let this be configureable? (ala #214 ?). I suppose the only reason one would not want the human readable representation is to preserve backwards compatibility with the format of older versions.

[dtolnay]

I would not attempt to make one version of bincode parse every bincode data ever written. People can depend on both 0.9 and 1.0, deserialize with 0.9, serialize with 1.0 if necessary to migrate data.

[dtolnay]

Marking for 1.0 because doing this later would be a breaking change.

[TyOverby]

@Marwes: there's no reason that this couldn't be configurable, but I'm wondering if we should just add it and make it the default before bincode hits 1.0.0.

[RReverser]

So what's the further plan for this? Is this going to wait for 1.0 or is there a chance this fix could be released earlier in minor update?

[TyOverby]

waiting for 1.0, which ideally will be released early next week.

[RReverser]

@TyOverby Obviously this is taking more than a week, which is understandable and I'm fine with, but could you please publish intermediate version with this fix?

[TyOverby]

@RReverser: published!

[RReverser]

@TyOverby Thank you!

[RReverser]

Oh, you published actual 1.0.0 release? Awesome!

[TyOverby]

Just for you @RReverser! :D