Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_human_readable() is set to true #225

Closed
Emerentius opened this issue Jan 17, 2018 · 1 comment
Closed

is_human_readable() is set to true #225

Emerentius opened this issue Jan 17, 2018 · 1 comment

Comments

@Emerentius
Copy link

@Emerentius Emerentius commented Jan 17, 2018

The serde docs state

Generally text-based formats like JSON and YAML will prefer to use the human-readable one and binary formats like Bincode will prefer the compact one.

I was quite surprised when I noticed that bincode wrote the text representation of my struct (with a manual Serialize impl that checks is_human_readable()).

Either this crate should overwrite the default implementation of that function from serde::Serializer and serde::Deserializer or the serde docs should take another format as example.

@Emerentius
Copy link
Author

@Emerentius Emerentius commented Jan 17, 2018

I see now that there was already a change committed as well as another issue. Strange that I missed that in my issue search.

@Emerentius Emerentius closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.