Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding should return how much of the buffer was used #35

Closed
reem opened this issue May 1, 2015 · 2 comments
Closed

Decoding should return how much of the buffer was used #35

reem opened this issue May 1, 2015 · 2 comments

Comments

@reem
Copy link
Contributor

@reem reem commented May 1, 2015

This is so it is possible to parse from a large (e.g. ring) buffer and know when the current thing we are decoding has ended and another message has begun.

@TyOverby
Copy link
Collaborator

@TyOverby TyOverby commented May 1, 2015

Good idea; I actually already collect that information, I'll just need to export it.

@TyOverby TyOverby closed this in afeb25b May 1, 2015
@TyOverby
Copy link
Collaborator

@TyOverby TyOverby commented May 19, 2015

I'm reverting this because I don't think that the information is useful enough to put on the basic functions.

You can still access this information by constructing the DecoderReader, decoding from that, then asking how many bytes were read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.