Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serde 0.9.X #92

Closed
dorny opened this issue Jan 17, 2017 · 5 comments
Closed

Support serde 0.9.X #92

dorny opened this issue Jan 17, 2017 · 5 comments
Assignees

Comments

@dorny
Copy link

@dorny dorny commented Jan 17, 2017

Serde 0.9.0-rc1 is out (serde-rs/serde#668) and there are some breaking changes.
It would be great to have a support for it. Thanks.

@TyOverby TyOverby self-assigned this Jan 17, 2017
@dorny
Copy link
Author

@dorny dorny commented Jan 17, 2017

I have looked for breaking changes which causes troubles:
serde-rs/serde@88debb3 - Remove SeqVisitor::end() and MapVisitor::end()
serde-rs/serde@738aa31 - Enforce correct use of Deserialize trait
Most probably there will be more, these two are just result of my quick research (hoping it will be easy enough to be able to fix it by myself).

@dtolnay
Copy link
Collaborator

@dtolnay dtolnay commented Jan 17, 2017

Here are the changes going into 0.9.0. You can see the ones marked with the "breaking change" label. https://github.com/serde-rs/serde/milestone/16?closed=1

In the next couple days as the release settles down, I will write up a thorough explanation of the changes and motivation for them as well as helpful notes for migrating. I would advise waiting for that before attempting to update. Then you will have about a week and a half to update in time for the Rust 1.15 release.

@ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Jan 31, 2017

I've been working on this since I need it for a project I'm working on. I've got the rewrite almost complete apart from deserialize_enum. I'm not too familiar with serde or bincode but it seems that now for some reason the DeserializeSeed wants to call deserialize_struct_field.

@dtolnay
Copy link
Collaborator

@dtolnay dtolnay commented Jan 31, 2017

This is a bug: serde-rs/serde#722. I posted a workaround in that issue. XDR has been using it successfully.

@ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Jan 31, 2017

Wow, that was a fast response! I implemented the workaround and all the tests passed.

@TyOverby TyOverby closed this in #93 Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.