Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the fast path for deserializing bytes::{Bytes, ByteBuf}. #116

Closed
wants to merge 1 commit into from
Closed

Use the fast path for deserializing bytes::{Bytes, ByteBuf}. #116

wants to merge 1 commit into from

Conversation

@khuey
Copy link
Contributor

khuey commented Feb 23, 2017

On a workload I have that makes heavy use of ByteBuf this cuts the time to execute by one order of magnitude.
@khuey
Use the fast path for deserializing bytes::{Bytes, ByteBuf}.
Loading status checks…
70cdf3e 
On a workload I have that makes heavy use of ByteBuf this cuts the time to execute by one order of magnitude.
@TyOverby
Copy link
Collaborator

TyOverby commented Feb 23, 2017

Thanks for the contribution! However, it looks like #115 beat you to it by several hours.

Because @tikue got there first I'm going to take that PR. There are a few minor differences between the PRs, and I'll suggest that @tikue use read_exact like you did.
@TyOverby TyOverby closed this Feb 23, 2017
@TyOverby TyOverby mentioned this pull request Feb 23, 2017
Merged
@khuey
Copy link
Contributor Author

khuey commented Feb 23, 2017

Ha, so it did. Thanks!
@khuey khuey deleted the khuey:fast-bytes branch Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@khuey @TyOverby
You can’t perform that action at this time.