Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to the latest rustc-serialize #12
Merged
+15
−33
Conversation
| V: Encodable<EncoderWriter<'a, MemWriter>, IoError> + | ||
| Decodable<DecoderReader<'a, MemReader>, IoError> + | ||
| PartialEq + Show>(element: V) { | ||
| fn the_same<'a, V>(element: V) where V: Encodable, V: Decodable, V: PartialEq, V: Show { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bitonic
Jan 7, 2015
Author
Collaborator
I find the where notation nicer for long lists, and I believe the + syntax is sort of frowned upon.
In other words, no good reason :).
src/lib.rs
Outdated
| @@ -43,19 +41,13 @@ where T: Decodable<DecoderReader<'a, MemReader>, IoError> { | |||
| // the current json encoder in the stdlib | |||
|
|
|||
| // TODO: Make code safe https://github.com/rust-lang/rust/issues/14302 | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/lib.rs
Outdated
| t.encode(std::mem::transmute(&mut writer::EncoderWriter::new(w, size_limit))) | ||
| } | ||
| pub fn encode_into<T: Encodable, W: Writer>(t: &T, w: &mut W, size_limit: SizeLimit) -> IoResult<()> { | ||
| t.encode(&mut writer::EncoderWriter::new(w, size_limit)) | ||
| } | ||
|
|
||
| // TODO: Make code safe https://github.com/rust-lang/rust/issues/14302 |
This comment has been minimized.
This comment has been minimized.
|
As an aside, feel free to add yourself to the owners list in |
TyOverby
added a commit
that referenced
this pull request
Jan 7, 2015
Update to the latest rustc-serialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bitonic commentedJan 7, 2015
No description provided.