Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmake SizeLimit a trait #124
Merged
Conversation
|
cc @dtolnay |
|
This didn't make much of a difference in #123... BeforeAfterI don't have time to review the code tonight but maybe read through the code again and focus on places where the Infinite / &[u8] case has different behavior compared to my implementation. |
src/lib.rs
Outdated
| Infinite, | ||
| Bounded(u64) | ||
| pub trait SizeLimit { | ||
| #[inline(always)] |
This comment has been minimized.
This comment has been minimized.
dtolnay
Feb 25, 2017
Collaborator
My understanding is this doesn't do anything, the compiler just ignores it. The inline attribute needs to go where the body of the method is defined.
This comment has been minimized.
This comment has been minimized.
|
the serde-rs/bench test is a really micro-benchmark. I think that I'm going to spend some time and make a benchmarking system that has a larger variety of tests. |
bors-servo
added a commit
to servo/ipc-channel
that referenced
this pull request
Mar 21, 2017
Switch to bincode 1.0.0-alpha6 Infinite struct Ref: servo/bincode#124 `SizeLimit` has been refactored to a trait, and `Infinite` is now a struct which implements that trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TyOverby commentedFeb 25, 2017
Closes #121