Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake example work with serde #131
Merged
+18
−31
Conversation
|
I think the asserts were useful because it demonstrated the compactness of the bincode format without having to run the example. With the new design, the user would need to run the example to determine the size of the encoded data. |
|
@slyrz: Ah, thanks for the PR, can't believe I missed these! Like @dgriffen said, I would prefer that the asserts are left as-is. The examples are mainly supposed to be read, not executed. (that said, they should still build and run). |
|
I do like the idea of printing the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
slyrz commentedMar 7, 2017
This PR makes the old example work with serde. It also replaces the asserts
with some output of the encoded/decoded structs, because asserts are boring and an example needs some action.