Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to serde 1.0 branch #149

Merged
merged 2 commits into from Apr 19, 2017
Merged

Update to serde 1.0 branch #149

merged 2 commits into from Apr 19, 2017

Conversation

@dtolnay
Copy link
Collaborator

dtolnay commented Apr 17, 2017

TODO:

  • Support deserializing borrowed data.
@dtolnay dtolnay added the wip label Apr 17, 2017
@TyOverby
Copy link
Collaborator

TyOverby commented Apr 18, 2017

Ah! You beat me to it! I got about half of this done over the weekend, so I'm super happy that you finished up!

According to bincode_bench, this upgrade is faster too!

@TyOverby
Copy link
Collaborator

TyOverby commented Apr 18, 2017

Btw, Servo is planning on adding support for bincode in webrender here: servo/webrender#1124 (comment)

They're concerned about deserializing perf, so I was wondering if you had some insight into why deserializing seems to be a lot more costly than serializing. Their structures seem to be mostly structs and enums, and I was wondering if there is anything we could do to speed it up?

@dtolnay
Copy link
Collaborator Author

dtolnay commented Apr 19, 2017

@TyOverby I'll leave the zero-copy refactor to you.

@TyOverby
Copy link
Collaborator

TyOverby commented Apr 19, 2017

@dtolnay Sounds good. Merge now, zero copy later?

@dtolnay
Copy link
Collaborator Author

dtolnay commented Apr 19, 2017

Sure, just make sure not to publish it until then. Maybe stick a publish = false in Cargo.toml.

@TyOverby
Copy link
Collaborator

TyOverby commented Apr 19, 2017

👍

@TyOverby TyOverby merged commit 8c9e236 into master Apr 19, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@TyOverby
Copy link
Collaborator

TyOverby commented Apr 19, 2017

added publish=false

@dtolnay dtolnay removed the wip label Apr 20, 2017
@dtolnay dtolnay deleted the 1.0 branch Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.