Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer bug #152

Merged
merged 2 commits into from Apr 21, 2017
Merged

Fix buffer bug #152

merged 2 commits into from Apr 21, 2017

Conversation

@TyOverby
Copy link
Collaborator

TyOverby commented Apr 21, 2017

This PR does two things:

  • Changes read_vec to use the special BincodeRead buffer to speed up reading out of a &[u8].
  • Fixes a bug in IoReadReader::forward_read_bytes and IoReadReader::forward_read_str where the internal buffer length wasn't changed via set_len.
TyOverby added 2 commits Apr 21, 2017
@TyOverby
fix buffer length bug
Loading status checks…
8e912f7
@TyOverby
factor out some common functionality
Loading status checks…
44c0ff6
@TyOverby TyOverby requested a review from dtolnay Apr 21, 2017
@dtolnay dtolnay merged commit 71a8a47 into master Apr 21, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dtolnay dtolnay deleted the fix-buffer-bug branch Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@TyOverby @dtolnay
You can’t perform that action at this time.