Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: avoid awkward language #186

Merged
merged 1 commit into from Jul 22, 2017
Merged

readme: avoid awkward language #186

merged 1 commit into from Jul 22, 2017

Conversation

@tshepang
Copy link
Contributor

tshepang commented May 31, 2017

Also, make Vec parameter visible when rendered
@dtolnay
dtolnay requested changes Jul 22, 2017
View changes
Copy link
Collaborator

dtolnay left a comment

We decode from &[u8], not from Vec<u8>. Could you suggest a change that would communicate this more clearly?
@tshepang
readme: deserializer/decoder actually accepts `&[u8]`, not `Vec<u8>`
Loading status checks…
dd69568
@tshepang
Copy link
Contributor Author

tshepang commented Jul 22, 2017

fixed
@dtolnay
dtolnay approved these changes Jul 22, 2017
View changes
Copy link
Collaborator

dtolnay left a comment

Thanks.
@dtolnay dtolnay merged commit 8c7aaba into servo:master Jul 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tshepang tshepang deleted the tshepang:foo branch Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tshepang @dtolnay
You can’t perform that action at this time.