Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove naming redundancy with IoError #194

Merged
merged 2 commits into from Jul 22, 2017
Merged

Remove naming redundancy with IoError #194

merged 2 commits into from Jul 22, 2017

Conversation

@ZoeyR
Copy link
Collaborator

ZoeyR commented Jul 19, 2017

Closes #178
@ZoeyR
Remove naming redundancy with IoError
Loading status checks…
8a5ced4
@TyOverby
Copy link
Collaborator

TyOverby commented Jul 20, 2017

Looks like this conflicted with your other PR. Looks good though!
@ZoeyR
Merge branch 'master' into io-variant-names
Loading status checks…
c50d180
@dtolnay dtolnay merged commit c50d180 into servo:master Jul 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dtolnay added a commit that referenced this pull request Jul 22, 2017
@dtolnay
Merge pull request #194 from dgriffen/io-variant-names
Verified
This commit was signed with a verified signature.
dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
5d84e58
dtolnay added a commit that referenced this pull request Jul 22, 2017
@dtolnay
Correctly report the cause of IO error
Verified
This commit was signed with a verified signature.
dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
1020771 
This was fixed in #195 but unintentionally reverted in #194.
dtolnay added a commit that referenced this pull request Jul 22, 2017
@dtolnay
Revert whitespace changes from #194
Verified
This commit was signed with a verified signature.
dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
Loading status checks…
7223f37
@dtolnay
dtolnay reviewed Jul 22, 2017
View changes
Copy link
Collaborator

dtolnay left a comment

Thanks! I merged this along with 1020771 to fix the merge with #195 and 7223f37 to clean up the whitespace changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ZoeyR @TyOverby @dtolnay
You can’t perform that action at this time.