Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReject trailing bytes #198
Merged
Conversation
|
Finally got around to updating this to current bincode after 2.5 years |
|
I've realized that this might be considered a breaking change. |
|
I was the person who was saying that this should be considered a breaking change, fwiw. |
codecov-commenter
commented
May 24, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 61.33% 61.42% +0.08%
==========================================
Files 10 11 +1
Lines 807 827 +20
==========================================
+ Hits 495 508 +13
- Misses 312 319 +7
Continue to review full report at Codecov.
|
|
cc @strega-nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ZoeyR commentedJul 24, 2017
Closes #193
There were two design possibilities I considered for tackling this problem. The current one changes the impls on
SliceReaderto be impls for&mut SliceReader. This allows me to access it after passing it to the deserializer. The other option would be to allowpub(restricted)access to the reader field of the deserializer and access it from there.