Encode/decode to/from references to readers

[tedsta]

I borrowed the pattern used in the json encoder in the standard library. The code uses an unsafe block, but I guess it can be removed whenever rust-lang/rust#14302 is resolved. All the tests pass at least :P

[TyOverby]

Looks good! Thanks for the pull request! Before I merge, why is R forced to implement Buffer? I'd like to keep the constraints as low as possible, but if you have a good reason, I'll merge this.

Also, do you want to be added as a contributor?

[TyOverby]

Why is this R requiring Buffer?

[tedsta]

std::io::Reader by itself doesn't have a read_char method, which was needed here: https://github.com/TyOverby/binary-encode/pull/2/files#diff-fe8c5b0f0b5c8a2045f912ca4aaaefc7L74

Before, the code got around that by using a BufferedReader. Luckily, MemReader implements Buffer, which does have a read_char method. Now, the user can choose whether or not to use a buffered reader. I think that's a nice property?

No need to add me as a contributor, I'll just do the pull request thang 'cause it's fun.

Thanks for writing this btw! They should put something like this in the standard library, especially since they even included json. This library is going to clean up a ton of binary serialization code in my project.

[TyOverby]

Ok, yeah, that makes sense! Thanks for your contribution! I'll merge this
when I get home.

On Thursday, October 9, 2014, Theodore DeRego notifications@github.com
wrote:

std::io::Reader by itself doesn't have a read_char method, which was
needed here:
https://github.com/TyOverby/binary-encode/pull/2/files#diff-fe8c5b0f0b5c8a2045f912ca4aaaefc7L74

Before, the code got around that by using a BufferedReader. Luckily,
MemReader implements Buffer, which does have a read_char method. Now, the
user can choose whether to use a buffered reader. I think that's a nice
property?

No need to add me as a contributor, I'll just do the pull request thang
'cause it's fun.

Thanks for writing this btw! They should put something like this in the
standard library, especially since they even included json. This library is
going to clean up a ton of binary serialization code in my project.

—
Reply to this email directly or view it on GitHub
#2 (comment).

-Ty Overby
:wq