Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow serialized types to use a more compact representation ... #217
Conversation
... by utilizing that bincode is not human readable. Uses the changes in serde-rs/serde#1044 which allows data formats to report that they are not human readable. This lets certain types serialize themselves into a more compact form as they know that the serialized form does not need to be readable. Closes #215 BREAKING CHANGE This changes how types serialize themselves if they detect the `is_human_readable` state.
|
I'm going to hold off on merging this until I talk to some people that are using bincode. I only know of one group that is using bincode and storing the data on disk. |
|
@TyOverby Any movement on this? |
|
No reason for this to not be merged right now, but I'm going to hold off on publishing until I land the other breaking changes. This change will likely be a part of 1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Marwes commentedNov 2, 2017
... by utilizing that bincode is not human readable.
Uses the changes in serde-rs/serde#1044 which
allows data formats to report that they are not human readable. This
lets certain types serialize themselves into a more compact form as they
know that the serialized form does not need to be readable.
Closes #215
BREAKING CHANGE
This changes how types serialize themselves if they detect the
is_human_readablestate.