Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for 128bit numbers #237
Conversation
|
I could rejig the |
|
This looks great! Thanks! My only request would be adding a test that utilizes the full range of the 128 bit numbers. |
|
I'm totally fine with the travis output spew as I rarely need to look at it :D As for pinning the version, I don't know? It looks like serde tests with
If you'd like, feel free to build these into this PR (in a new commit) and we can enable testing on these channels. |
|
@TyOverby It looks like we need |
|
Looks great, thanks for the contributions! |
KodrAus commentedMay 30, 2018
Closes #236
This PR adds support for encoding/decoding
i128andu128which were stabilized inrustc1.26.0, and supported as ofserde1.0.60.There's a new a disabled-by-default
i128feature flag inbincode, which enables support for 128bit numbers. Ifbincodeis compiled on a version of Rust that supports 128bit numbers but doesn't have thei128feature enabled then we'll return a custom error at runtime suggesting they enable the feature.If there's anything you'd like changed let me know. Thanks!