Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce `Config::deserialize_seed` for exposing serde's statefull deserialization. #246
Conversation
…eser.
|
Looks good! Could you add a few tests? Maybe one test with the default configuration and one with a non-default configuration? |
|
Makes sense, tests added. -- Btw., it looks like the source code of bincode is not formatted at all. Probably, this could be done to make it easier for people who are using |
|
Thanks! And yeah, I should probably format the code. |
|
I just formatted the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
boxdot commentedSep 3, 2018
This is needed if one wants to use stateful deserialization, since the
SliceReaderis public but not part of the public API, andbincode::Deserializeris private.