Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake i128 support automatic for supporting Rustc versions #261
+31
−22
Conversation
Uses autocfg
|
When I get home I'll release this! To confirm: this is a minor-release bump correct? |
|
Yes, it shouldn't have any breaking changes (hence keeping the dummy feature). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dhardy commentedJan 28, 2019
•
edited
Fix #250.
Uses autocfg. If you prefer, I can avoid this as @BurntSushi did in byteorder, but this seems like an apt tool for the job so worth making more popular.
Tested on Rustc 1.22.1, 1.31.1 and a recent nightly.