Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 2.0. #304

Closed
wants to merge 2 commits into from
Closed

Publish 2.0. #304

wants to merge 2 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Mar 9, 2020

Any new version that includes e30e91e has to be a major version bump. While on one hand it would be nice to batch a bunch of breaking changes together, that would require a maintainer that is paying attention to this crate and has hopes and dreams for it, and that is not a good description of bincode's current maintainers :)

jdm added 2 commits Mar 9, 2020
Copy link
Collaborator

dtolnay left a comment

You should not do 2.0 for that change.

  • The way to make that change backward compatibly is to deprecate SerializerAcceptor keeping the old signature and make a new trait with a different name with the new signature and a blanket impl for T: SerializerAcceptor.

  • But SerializerAcceptor is not a public API anyway so you can just change it.

    bincode/src/lib.rs

    Lines 168 to 174 in a6925b4

    /// Executes the acceptor with a serde::Serializer instance.
    /// NOT A PART OF THE STABLE PUBLIC API
    #[doc(hidden)]
    pub fn with_serializer<A, W>(writer: W, acceptor: A) -> A::Output
    where
    A: SerializerAcceptor,
    W: std::io::Write,

@dtolnay dtolnay closed this Mar 9, 2020
@dtolnay dtolnay deleted the jdm-patch-1 branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.