Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVarint enum tags and lengths #306
Conversation
|
@dtolnay can I get a review of this? |
|
Hi @ZoeyR, I think #294 (review) applies here. I think this is useful but it would be better to pursue in a different library. |
|
This needs some changes, but otherwise, is a really good changeset. |
codecov-io
commented
Apr 17, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 63.18% 57.84% -5.34%
==========================================
Files 7 7
Lines 622 733 +111
==========================================
+ Hits 393 424 +31
- Misses 229 309 +80
Continue to review full report at Codecov.
|
fabricedesre
commented
May 1, 2020
|
Hi! Is there anything blocking that to land? |
|
@fabricedesre COVID, but also I'd like to add varint encoding forall integers. |
Zaxar163
commented
May 17, 2020
|
When this PR will be accepted? |
|
@Zaxar163 once we've worked out the kinks with signed number varints. |
alanjds
commented
Aug 19, 2020
|
Hi. When will this be released as a crate? |
|
Hi @alanjds this was release a few months ago as part of bincode 1.3 |
ZoeyR commentedMar 14, 2020
•
edited
Resolves #319
This is a continuation of PR #271 based on feedback in that PR. The primary change is to use a config option instead of a feature in order to use varint sequence lengths and discriminants.