Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upremove unsafe code in IoReader #309
Merged
Conversation
|
Could you upload some graphs of the benchmarks? Otherwise, this is a great change imo! |
|
I tested on a different machine and got different results for which implementation came in first. So based on the machine it might end up being slightly slower. I think the trade-off is still worth it to avoid undefined behaviour, especially in a serialization library that might interface with remote machines. Once rust resolves rust-lang/rust#42788 we can evaluate changing the implementation. |
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ZoeyR commentedMar 15, 2020
Fully fixes #260
I ran benchmarks with https://github.com/erickt/rust-serialization-benchmarks and couldn't find any appreciable difference in the time it took to execute. If anything, the new method runs faster.