Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refbox: add Debug impl #31

Merged
merged 1 commit into from Apr 3, 2015
Merged

refbox: add Debug impl #31

merged 1 commit into from Apr 3, 2015

Conversation

@jmesmon
Copy link
Contributor

jmesmon commented Apr 3, 2015

Allows #[derive(Debug)] to work with things containing RefBox.

Not sure adding impls like this is sustainable.

I used to be able to do

impl<'a> fmt::Debug for bincode::RefBox<'a, MyLocalType> {
    fn fmt(&self, fmt: &mut fmt::Formatter) -> Result<(), fmt::Error> {
        write!(fmt, "RefBox({:?})", *self)
    }
}

Locally, but recent rust has forbidden this.

@jmesmon jmesmon force-pushed the jmesmon:me/refbox-debug branch from 2d0ecf5 to abeabe3 Apr 3, 2015
@TyOverby
Copy link
Collaborator

TyOverby commented Apr 3, 2015

Not implementing Debug was a mistake on my part. Thanks!

TyOverby added a commit that referenced this pull request Apr 3, 2015
refbox: add Debug impl
@TyOverby TyOverby merged commit fe065dc into servo:master Apr 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmesmon jmesmon deleted the jmesmon:me/refbox-debug branch Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.