Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor config module #323

Merged
merged 4 commits into from May 19, 2020
Merged

refactor config module #323

merged 4 commits into from May 19, 2020

Conversation

@ZoeyR
Copy link
Collaborator

ZoeyR commented May 19, 2020

Closes #320

Break up the config module into one submodule per configuration option. This commit also changes the default configuration with the new options system to be varint (the old system still uses fixint to preserve backwards compatibility).

ZoeyR added 2 commits May 19, 2020
Break up the config module into one submodule per configuration
option. This commit also changes the default configuration with
the new options system to be varint (the old system still uses
fixint to preserve backwards compatibility).
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #323 into master will increase coverage by 0.56%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   60.77%   61.33%   +0.56%     
==========================================
  Files           7       10       +3     
  Lines         803      807       +4     
==========================================
+ Hits          488      495       +7     
+ Misses        315      312       -3     
Impacted Files Coverage Δ
src/config/legacy.rs 0.00% <0.00%> (ø)
src/config/mod.rs 40.00% <40.00%> (ø)
src/config/limit.rs 45.45% <45.45%> (ø)
src/config/int.rs 55.10% <55.10%> (ø)
src/lib.rs 75.00% <77.77%> (-8.34%) ⬇️
src/error.rs 4.54% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263fb94...7049e36. Read the comment docs.

ZoeyR added 2 commits May 19, 2020
@ZoeyR ZoeyR merged commit 7382ec4 into servo:master May 19, 2020
9 checks passed
9 checks passed
Check (stable)
Details
Check (beta)
Details
Check (nightly)
Details
Check (1.18.0)
Details
Test (stable)
Details
Test (beta)
Details
Test (nightly)
Details
Lints
Details
Code Coverage
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.