Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logic error in fill_buffer #336

Merged
merged 4 commits into from Jun 24, 2020
Merged

fix logic error in fill_buffer #336

merged 4 commits into from Jun 24, 2020

Conversation

@ZoeyR
Copy link
Collaborator

ZoeyR commented Jun 24, 2020

Closes #335

@ZoeyR ZoeyR requested a review from dtolnay Jun 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #336 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   61.42%   61.40%   -0.02%     
==========================================
  Files          11       11              
  Lines         827      824       -3     
==========================================
- Hits          508      506       -2     
+ Misses        319      318       -1     
Impacted Files Coverage Δ
src/lib.rs 75.00% <ø> (ø)
src/de/read.rs 53.84% <100.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fa06e...40074e0. Read the comment docs.

Copy link
Collaborator

dtolnay left a comment

Implementation looks fine. Is there a way to add a test with a Deserialize impl for which this makes a difference? It's weird that this wouldn't have been covered by the test suite.

@ZoeyR
Copy link
Collaborator Author

ZoeyR commented Jun 24, 2020

I can design a small unit test that makes sure this function behaves properly. The test suite probably doesn't have complex enough types to trigger this.

ZoeyR added 2 commits Jun 24, 2020
@ZoeyR ZoeyR requested a review from dtolnay Jun 24, 2020
Copy link
Collaborator

dtolnay left a comment

Thanks!

@ZoeyR ZoeyR merged commit 1b3c88a into master Jun 24, 2020
9 checks passed
9 checks passed
Check (stable)
Details
Check (beta)
Details
Check (nightly)
Details
Check (1.18.0)
Details
Test (stable)
Details
Test (beta)
Details
Test (nightly)
Details
Lints
Details
Code Coverage
Details
@ZoeyR ZoeyR deleted the fix-buffer-fill branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.