Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix logic error in fill_buffer #336
Conversation
codecov-commenter
commented
Jun 24, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 61.42% 61.40% -0.02%
==========================================
Files 11 11
Lines 827 824 -3
==========================================
- Hits 508 506 -2
+ Misses 319 318 -1
Continue to review full report at Codecov.
|
|
Implementation looks fine. Is there a way to add a test with a Deserialize impl for which this makes a difference? It's weird that this wouldn't have been covered by the test suite. |
|
I can design a small unit test that makes sure this function behaves properly. The test suite probably doesn't have complex enough types to trigger this. |
|
Thanks! |
ZoeyR commentedJun 24, 2020
Closes #335