Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAddress questions regarding suitability for storage and untrusted inputs #346
Conversation
|
Please let me know if the style is fine; as the original |
codecov-commenter
commented
Aug 13, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 61.40% 63.47% +2.06%
==========================================
Files 11 11
Lines 824 824
==========================================
+ Hits 506 523 +17
+ Misses 318 301 -17
Continue to review full report at Codecov.
|
|
Also, I have no idea why changing the |
|
Only one minor nit. Otherwise everything looks good! Ignore the code coverage changes, rust is finicky about that. |
| configuration is used. This should ensure that later versions can still read | ||
| data produced by a previous versions of the library if no major version change | ||
| has occured. Beware that in the Rust ecosystem, for a `0.x` version, any change | ||
| in `x` is considered a **major** version change. |
This comment has been minimized.
This comment has been minimized.
ZoeyR
Aug 18, 2020
Collaborator
This last sentence is probably unnecessary since bincode is post 1.0
mbr commentedAug 13, 2020
Puts some prominent text into the
readme.mdregarding some use casesthat are likely to be common, along with a few hopefully helpful
pointers to avoid footguns.
Closes #345, closes #216, addresses #240, #266.