Address questions regarding suitability for storage and untrusted inputs#346
Conversation
Puts some prominent text into the `readme.md` regarding some use cases that are likely to be common, along with a few hopefully helpful pointers to avoid footguns. Closes bincode-org#345, closes bincode-org#216, addresses bincode-org#240, bincode-org#266.
|
Please let me know if the style is fine; as the original |
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 61.40% 63.47% +2.06%
==========================================
Files 11 11
Lines 824 824
==========================================
+ Hits 506 523 +17
+ Misses 318 301 -17
Continue to review full report at Codecov.
|
|
Also, I have no idea why changing the |
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Only one minor nit. Otherwise everything looks good! Ignore the code coverage changes, rust is finicky about that.
|
Three months for a single sentence is not a terribly speedy response, but if this is still good to go, I've submitted the fix. Sorry, I only ran into this after hitting the "mark all read" button on my email account =( |
|
Three months to respond to such a fix is also quite slow on my part 😅 |
ghost
merged commit 
|
Should I wait another three months to say "thank you"? ;) |
|
I'll skip the wait and say thanks right now. Much appreciated! :) |
4 participants
Puts some prominent text into the
readme.mdregarding some use casesthat are likely to be common, along with a few hopefully helpful
pointers to avoid footguns.
Closes #345, closes #216, addresses #240, #266.