Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTemporary serde dependency fix #57
Conversation
larsbergstrom
commented
Feb 28, 2016
|
r? @TyOverby Sorry to be pushy, but broken bincode on nightly is causing rippling CI failures across the entirety of Servo's dependency chain that uses it (many, many modules) and prevents us from landing any new PRs in those components. Thanks! |
|
Shouldn't ^0.6 already prevent 0.7 from being used? |
|
@tikue I think ^ allows minor version updates. At least it's compiling now for me when I use my fork as dependency instead of directly bincode |
|
I could be wrong, but I thought only when it's not a semver breaking If that's the case, my best guess for what's happening is that the version
|
|
I'll get on this. Do the tests work for you or is the CI broken? |
|
Tests are mostly fine, all visit_* methods on Serialize/Deserialize impls
|
|
I needed to update a few more things in the Cargo.toml, so I made this change and committed it. |
larsbergstrom
commented
Feb 29, 2016
|
@TyOverby Thanks a ton! |
reneeichhorn commentedFeb 28, 2016
As stated in #55 #56 builds are failing right now because of an update of serde.