Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary serde dependency fix #57

Closed
wants to merge 1 commit into from
Closed

Conversation

@reneeichhorn
Copy link

reneeichhorn commented Feb 28, 2016

As stated in #55 #56 builds are failing right now because of an update of serde.

@larsbergstrom
Copy link

larsbergstrom commented Feb 28, 2016

r? @TyOverby

Sorry to be pushy, but broken bincode on nightly is causing rippling CI failures across the entirety of Servo's dependency chain that uses it (many, many modules) and prevents us from landing any new PRs in those components. Thanks!

@tikue
Copy link
Contributor

tikue commented Feb 28, 2016

Shouldn't ^0.6 already prevent 0.7 from being used?

@reneeichhorn
Copy link
Author

reneeichhorn commented Feb 28, 2016

@tikue I think ^ allows minor version updates. At least it's compiling now for me when I use my fork as dependency instead of directly bincode

@tikue
Copy link
Contributor

tikue commented Feb 28, 2016

I could be wrong, but I thought only when it's not a semver breaking
update, and for versions less than 0, 0.X => 0.Y is breaking but 0.X.Y =>
0.X.Z is not breaking.

If that's the case, my best guess for what's happening is that the version
on crates.io was published before the caret restriction was added.
On Feb 28, 2016 2:06 PM, "Rene Eichhorn" notifications@github.com wrote:

@tikue https://github.com/tikue I think ^ allows minor version updates.


Reply to this email directly or view it on GitHub
#57 (comment).

@TyOverby
Copy link
Collaborator

TyOverby commented Feb 29, 2016

I'll get on this. Do the tests work for you or is the CI broken?

@tikue
Copy link
Contributor

tikue commented Feb 29, 2016

Tests are mostly fine, all visit_* methods on Serialize/Deserialize impls
change to serialize__/Deserialize__ respectively. About 100 LOC diff.
On Feb 29, 2016 9:32 AM, "Ty Overby" notifications@github.com wrote:

I'll get on this. Do the tests work for you or is the CI broken?


Reply to this email directly or view it on GitHub
#57 (comment).

@TyOverby
Copy link
Collaborator

TyOverby commented Feb 29, 2016

I needed to update a few more things in the Cargo.toml, so I made this change and committed it.

@TyOverby TyOverby closed this Feb 29, 2016
@larsbergstrom
Copy link

larsbergstrom commented Feb 29, 2016

@TyOverby Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.