Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Respect size limits in read_seq and read_map." #65

Merged
merged 1 commit into from Apr 4, 2016
Merged

Revert "Respect size limits in read_seq and read_map." #65

merged 1 commit into from Apr 4, 2016
+0 −24

Conversation

@TyOverby
Copy link
Collaborator

TyOverby commented Apr 3, 2016

This reverts commit 45fcb1c.
@TyOverby TyOverby force-pushed the revert-sizechecks branch from e545a71 to 838662f Apr 3, 2016
@TyOverby
Revert "Respect size limits in read_seq and read_map."
Loading status checks…
8e56022 
This reverts commit 45fcb1c.
@TyOverby TyOverby force-pushed the revert-sizechecks branch from 838662f to 8e56022 Apr 3, 2016
@TyOverby
Copy link
Collaborator Author

TyOverby commented Apr 3, 2016

@canndrew @nox

Since the fix landed in upstream rustc-serialize, the size checking to prevent OOM crashes are unnecessary. Please review when you have time!
@canndrew
Copy link
Contributor

canndrew commented Apr 4, 2016

Looks good to me!
@TyOverby
Copy link
Collaborator Author

TyOverby commented Apr 4, 2016

🎉
@TyOverby TyOverby merged commit 863fb40 into master Apr 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@TyOverby TyOverby deleted the revert-sizechecks branch Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@TyOverby @canndrew
You can’t perform that action at this time.