Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd cargo features for rustc-serialize and serde #70
+29
−4
Conversation
|
This seems reasonable! |
.travis.yml
Outdated
| @@ -25,3 +25,5 @@ script: | |||
| - multirust default $CHANNEL | |||
| - cargo build | |||
| - if [ $CHANNEL = 'nightly' ] ; then cargo test ; fi | |||
| - cargo build --no-default-features --features "rustc-serialize" | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good to me! If you squash these commits, I'll click the merge button! |
|
10 minutes please, I'll remember how to squash |
|
Actually, wait, I can squash during the merge. You don't need to do anything. Thanks for your contribution! |
|
Beautiful! It'll be also great to make a release so I could use this feature |
|
Yep, I'll publish a new version right now! |
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alexbool commentedApr 15, 2016
So you are allowed to depend only on what you use.
Tests depend heavily on both of these crates, so they only run with default features on.
So did example binary, I did not modify it for simplicity and clarity.