Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed size array deserialization #76

Merged
merged 3 commits into from Jun 19, 2016
Merged

Fixed size array deserialization #76

merged 3 commits into from Jun 19, 2016

Conversation

@0nkery
Copy link
Contributor

0nkery commented Jun 17, 2016

Fixes #74.

This PR in serde fixes this problem but I don't know when and how they will release patch.

Dmitry Shlagoff and others added 2 commits Jun 17, 2016
the_same([0u8; 19]);
}


This comment has been minimized.

@dtolnay

dtolnay Jun 17, 2016

Collaborator

Remove the extra newline

@dtolnay
Copy link
Collaborator

dtolnay commented Jun 17, 2016

This LGTM. We will fix this upstream in Serde in the next breaking release.

Dmitry Shlagoff
@0nkery
Copy link
Contributor Author

0nkery commented Jun 17, 2016

@TyOverby Tests aren't building due to #77.

@TyOverby
Copy link
Collaborator

TyOverby commented Jun 19, 2016

Checks look good! Thanks!

@TyOverby TyOverby merged commit d964b52 into servo:master Jun 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.