Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub used InvalidEncoding in serde+rustc_serialize so it shows in `cargo doc` #82

Merged
merged 2 commits into from Jul 8, 2016
Merged

pub used InvalidEncoding in serde+rustc_serialize so it shows in `cargo doc` #82

merged 2 commits into from Jul 8, 2016

Conversation

@Cobrand
Copy link
Contributor

Cobrand commented Jul 6, 2016

  • Removed some 'unused import' warnings
  • Made both fields of InvalidEncoding public so it can be used without Display or Debug traits (e.g. pattern matching)
Cobrand added 2 commits Jul 6, 2016
@Cobrand
Removed unused import warning
19a0eb4
@Cobrand
pub use InvalidEncoding in serde+rustc_serialize
Loading status checks…
dd86389 
* Made both fields of InvalidEncoding public so it can be used without Display or Debug traits (e.g. pattern matching)
* Export of InvalidEncoding in rustc_serialize/serde make them visible in `cargo doc`
@TyOverby
Copy link
Collaborator

TyOverby commented Jul 7, 2016

Looks good to me!

@nox ?
@dtolnay
Copy link
Collaborator

dtolnay commented Jul 7, 2016

LGTM
@TyOverby TyOverby merged commit aa0f980 into servo:master Jul 8, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TyOverby
Copy link
Collaborator

TyOverby commented Jul 8, 2016

Published to crates.io as 0.5.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Cobrand @TyOverby @dtolnay
You can’t perform that action at this time.