Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to serde 0.8.0 #84

Merged
merged 1 commit into from Jul 28, 2016
Merged

Update to serde 0.8.0 #84

merged 1 commit into from Jul 28, 2016

Conversation

@dtolnay
Copy link
Collaborator

dtolnay commented Jul 28, 2016

Supersedes #83.

@TyOverby
Copy link
Collaborator

TyOverby commented Jul 28, 2016

Does this serde update include any changes that would change the ordering of bytes produced by bincode?

@dtolnay
Copy link
Collaborator Author

dtolnay commented Jul 28, 2016

No. There are 3 user-facing changes but all are in deserialization:

  • deserialize_str used to not be implemented, meaning it forwarded to deserialize and failed. Now it is implemented to deserialize a &str. This affects only Deserialize types that used to fail and now succeed.
  • deserialize_struct_field fails with a better message.
  • deserialize_ignored_any fails with a better message.

As an incentive, I suspect you will see a nice performance improvement in serialization for both structs and vectors.

I can put together a test suite this weekend before you release to prove the bytes are the same.

@TyOverby
Copy link
Collaborator

TyOverby commented Jul 28, 2016

Sounds good. I was only asking because I wanted to know if I'd need to bump the version number. However, I'm pretty sure I need to bump the version anyway, simply because it's re-exporting serde which bumped to 0.8.0.

The test suite already makes sure that the rustc-serialize encoding is the same (byte for byte) as the serde encoding, so I'm not super worried.

Thanks for the contribution!

@TyOverby TyOverby merged commit fd17a5d into servo:master Jul 28, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TyOverby
Copy link
Collaborator

TyOverby commented Jul 28, 2016

Published to crates.io as 0.6.0

@dtolnay dtolnay deleted the dtolnay:up branch Jul 28, 2016
@nox nox mentioned this pull request Jul 30, 2016
23 of 23 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.