Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDelegate emit_enum_struct_variant calls to emit_enum_variant #89
Conversation
read_enum_struct_variant delegates calls to read_enum_variant which expects u32 prefix to encode a variant number. Previous implementation of emit_enum_struct_variant doesn't emit it, making serialized data invalid.
|
Looks good, thanks for catching this! Could you add a regression test that would fail on this case? |
|
Does it look better? :) |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nbaksalyar commentedNov 23, 2016
read_enum_struct_variantdelegates calls toread_enum_variantwhich expectsu32prefix to encode a variant number. Previous implementation ofemit_enum_struct_variantdoesn't emit it, making serialized data invalid.