Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol agnostic font links #46

Merged
merged 1 commit into from Nov 30, 2015
Merged

Protocol agnostic font links #46

merged 1 commit into from Nov 30, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 30, 2015

Review on Reviewable

@edunham
Copy link
Contributor

edunham commented Nov 30, 2015

I didn't know you could do that! 👍

edunham added a commit that referenced this pull request Nov 30, 2015
@edunham edunham merged commit d6ccfc4 into gh-pages Nov 30, 2015
@frewsxcv frewsxcv deleted the frewsxcv-patch-1 branch Nov 30, 2015
@edunham
Copy link
Contributor

edunham commented Nov 30, 2015

This doesn't seem to have fixed the fonts displaying on https://servo.github.io/blog.servo.org/ -- I suspect the CSS isn't getting loaded at all -- but it did get rid of the mixed content warning. Thanks!

@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 30, 2015

Yeah, the CSS is linked via something like <link rel="stylesheet" href="/css/basscss.css" type="text/css">. Since for GitHub Pages urls, the root is /<repo>, this won't work. I'm not sure of a great solution for this right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.