Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdditions to CFURL and CFBundle #101
Merged
+95
−6
Conversation
This comment has been minimized.
This comment has been minimized.
jdm
commented on core-foundation/src/bundle.rs in 27cbbba
May 22, 2017
|
executable |
This comment has been minimized.
This comment has been minimized.
jdm
commented on core-foundation/src/bundle.rs in 27cbbba
May 22, 2017
|
Executable |
|
Other than the spelling, this looks fine. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 23, 2017
Additions to CFURL and CFBundle I propose a few additions to CFBundle and CFURL APIs. Not sure how general they are, but they would be nice to have out of the box. The `CFURL::absolute_file_url` test is a bit big, but it demonstrates the need for `CFURL::absolute()`. I think `CFBundle::main_bundle()` should return an `Option` since `CFBundleGetMainBundle` can return NULL but that is a breaking change and I decided not to include it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/101) <!-- Reviewable:end -->
|
|
|
When will you be publishing the next version? |
|
Could you make a PR that updates the minor version in Cargo.toml? |
|
Published. |
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Fix memory safety problem in `CGDataProvider::from_buffer()`. The wrapper for that function made no attempt to ensure that the buffer would stay alive, and as a result use-after-free could easily occur. The fix is to require that the buffer be stuffed in an `Arc` box and to teach Core Graphics how to release the `Arc` when it's done with it. Related: #77. (This is basically a more minimal version of that PR. I had seen #77 but didn't realize that it was a memory safety problem! If you'd like to merge that PR instead, feel free.) r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/101) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mgoszcz2 commentedMay 22, 2017
•
edited by larsbergstrom
I propose a few additions to CFBundle and CFURL APIs. Not sure how general they are, but they would be nice to have out of the box.
The
CFURL::absolute_file_urltest is a bit big, but it demonstrates the need forCFURL::absolute().I think
CFBundle::main_bundle()should return anOptionsinceCFBundleGetMainBundlecan return NULL but that is a breaking change and I decided not to include it.This change is