Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CFBundle::private_frameworks_url() exposing CFBundleCopyPrivateFr… #103
Conversation
…ameworksURL().
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 16, 2017
Add CFBundle::private_frameworks_url() exposing CFBundleCopyPrivateFr… …ameworksURL(). If this is merged, would it be possible to cut a release after? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/103) <!-- Reviewable:end -->
|
@bors-servo: r- |
|
If you update the crate's version number, it will be very easy to publish a release after. |
|
@jdm what happened here? Did the subsequent r- pause the commit? Just wondering if I should bump the version in this PR or create a new PR. Thanks! |
|
Yes, bump the version in this PR please. |
|
|
|
Thanks Josh! |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 16, 2017
Add CFBundle::private_frameworks_url() exposing CFBundleCopyPrivateFr… …ameworksURL(). If this is merged, would it be possible to cut a release after? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/103) <!-- Reviewable:end -->
|
|
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add a binding to `CGFontGetUnitsPerEm()` Pathfinder 2 is using this. It saves a little bit of time and memory by avoiding creation of `CTFont` objects just to do this simple query. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/103) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nikhilm commentedJun 16, 2017
•
edited by larsbergstrom
…ameworksURL().
If this is merged, would it be possible to cut a release after?
This change is