Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable cargo doc/check on non-Darwin platforms #105
Closed
Conversation
|
|
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Reexport FFI functions that were made private for no reason <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/105) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JohnColanduoni commentedJul 12, 2017
•
edited by larsbergstrom
core-foundation-sys's build script causes
cargo docto fail on Linux, Windows, etc. by attempting to like with CoreFoundation.framework. This adds a target check to prevent attempting to link to the framework on platforms where it will not be present.This change is