Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zero-sized struct warning. #106. #107

Merged
merged 3 commits into from Jul 27, 2017
Merged

Remove zero-sized struct warning. #106. #107

merged 3 commits into from Jul 27, 2017
+9 −7

Conversation

@rthomas
Copy link
Contributor

rthomas commented Jul 27, 2017 •
edited by larsbergstrom

This change will fix the remaining warnings in servo/core-text-rs#62 when it is released and the core-text crate is updated.

This change is Reviewable
@rthomas
Remove zero-sized struct warning. #106.
Verified
This commit was signed with a verified signature.
rthomas Ryan Thomas
GPG key ID: 4555CD92DA9C1378 Learn about signing commits
Loading status checks…
b67ccaf
@rthomas
Copy link
Contributor Author

rthomas commented Jul 27, 2017

@jdm fyi.
@jdm
Copy link
Member

jdm commented Jul 27, 2017

Want to increase the version number in Cargo.toml as well so we can publish after merging the changes?
@rthomas
Copy link
Contributor Author

rthomas commented Jul 27, 2017

Ack, will do for core-graphics as well.
@rthomas
Bump version number to 0.4.2.
Verified
This commit was signed with a verified signature.
rthomas Ryan Thomas
GPG key ID: 4555CD92DA9C1378 Learn about signing commits
Loading status checks…
4c83733
@rthomas
Copy link
Contributor Author

rthomas commented Jul 27, 2017

I've bumped the version number.
@jdm
Copy link
Member

jdm commented Jul 27, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

📌 Commit 4c83733 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

⌛ Testing commit 4c83733 with merge ca298a9...
bors-servo added a commit that referenced this pull request Jul 27, 2017
@bors-servo
Auto merge of #107 - rthomas:106-warnings, r=jdm
Loading status checks…
ca298a9 
Remove zero-sized struct warning. #106.

This change will fix the remaining warnings in servo/core-text-rs#62 when it is released and the core-text crate is updated.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/107)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

💔 Test failed - status-travis
@jdm
Copy link
Member

jdm commented Jul 27, 2017 

error: use of extern static requires unsafe function or block (error E0133)

   --> src/runloop.rs:128:45

    |

128 |         run_loop.add_timer(&run_loop_timer, kCFRunLoopDefaultMode);

    |                                             ^^^^^^^^^^^^^^^^^^^^^

    |

    = note: #[deny(safe_extern_statics)] on by default

    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

    = note: for more information, see issue #36247 <https://github.com/rust-lang/rust/issues/36247>

error: aborting due to previous error

error: Could not compile `core-foundation`.

Want to fix this too?
@rthomas
Copy link
Contributor Author

rthomas commented Jul 27, 2017

Yep, will take a look.
@rthomas
Wrap the test in `unsafe` to prevent E0133.
Verified
This commit was signed with a verified signature.
rthomas Ryan Thomas
GPG key ID: 4555CD92DA9C1378 Learn about signing commits
Loading status checks…
a37ecf5 
E0133 has gone from warning to error on nightly now, this fix allows the
tests to pass on nightly.
@jdm
Copy link
Member

jdm commented Jul 27, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

📌 Commit a37ecf5 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

⌛ Testing commit a37ecf5 with merge 5895274...
bors-servo added a commit that referenced this pull request Jul 27, 2017
@bors-servo
Auto merge of #107 - rthomas:106-warnings, r=jdm
Loading status checks…
5895274 
Remove zero-sized struct warning. #106.

This change will fix the remaining warnings in servo/core-text-rs#62 when it is released and the core-text crate is updated.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/107)
<!-- Reviewable:end -->
@rthomas
Copy link
Contributor Author

rthomas commented Jul 27, 2017

Pushed a commit to the PR that fixes this - as it was in the tests I figured wrapping the invocation in unsafe was acceptable.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

☀️ Test successful - status-travis
Approved by: jdm
Pushing 5895274 to master...
@bors-servo bors-servo merged commit a37ecf5 into servo:master Jul 27, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
jdm pushed a commit that referenced this pull request Feb 1, 2018
@bors-servo
Auto merge of #107 - nox:bump, r=jdm
2a080ac 
Bump version to 0.12.2

This includes CGFont::create_copy_from_variations.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/107)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@rthomas @jdm @bors-servo
You can’t perform that action at this time.