Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport converting non-utf8 paths to CFURLs #120
Merged
Conversation
|
r? @SimonSapin |
|
Does core-foundation even exist on non-OS-X? |
|
Yeah, you can compile it for a variety of platforms. Windows is explicitly
supported. I don't think this crate supports that, but I didn't want to
preclude it from happening.
|
|
Alright. Looks good! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 20, 2017
Support converting non-utf8 paths to CFURLs <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/120) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrmuizel commentedOct 19, 2017
•
edited by larsbergstrom
This change is