Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement to_path() to convert CFURLs to PathBufs. #122
+26
−7
Conversation
core-foundation/src/url.rs
Outdated
| // implementing this on Windows is more complicated because of the different OsStr representation | ||
| unsafe { | ||
| let mut buf: [u8; PATH_MAX as usize] = mem::uninitialized(); | ||
| CFURLGetFileSystemRepresentation(self.0, true as Boolean, buf.as_mut_ptr(), buf.len() as CFIndex); |
This comment has been minimized.
This comment has been minimized.
jdm
Oct 20, 2017
Member
This returns false if an error occurred, so we should make this method return None if that occurs.
This lets us roundtrip Paths through CFURLs
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 20, 2017
Implement to_path() to convert CFURLs to PathBufs. This lets us roundtrip Paths through CFURLs <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/122) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrmuizel commentedOct 20, 2017
•
edited by larsbergstrom
This lets us roundtrip Paths through CFURLs
This change is